I think I have an addiction...
Basic bitch Xbox controller - 8/10. Series X version is a downgrade from the old X1X controller imo. I really don't like the shitty d-pad they brought over from the elite. This is also the #1 reason I would never spend the money for an elite.
Dual Sense - 5/10 (7/10 with eXtremeRate 4 metal back button kit). I dislike pretty much everything about this controller. Haptics are the shittiest gimmick since the Wiimote. Face buttons are mushy. Sticks are too short and my fpsfreeks don't fit quite right (too tight, and they leave a mark if left on). It has ridiculously short battery life, and Sony still hasn't fixed the charging problems that have been around since PS5 release. DualShock 4 was just superior in every way.
Switch Pro - 7/10. Pretty similar to the Xbox controller, just a bit smaller and stupidly overpriced for what it is.
PowerA Fusion Pro 2 (Xbox + PC, $80) - 8.5/10. Basically a knock off of the elite controller with all the same accessories like back paddles, swappable thumbsticks of various heights, trigger locks, swappable faceplates, etc., but MS are dicks and use a proprietary wireless protocol instead of Bluetooth, and then refuse to allow any third party to use this protocol. Since it's MS that forces it to be wired I only knock off .5 because of it. The headset jack is really handy and includes a volume control and mic mute button. Everything else about it is excellent and the only criticism I have is that the rumble isn't that great and over time it turned into a rattle. Also, it's a little too easy to knock the back paddles out of their housing. I've had it for 3+ years and it's my most used controller on my most used system (plus some PC use too) so I can't really complain. Oh, and it comes with a really nice case too.
PowerA Fusion Pro 3 (Xbox + PC, $80) - 9.5/10. Very similar to the Pro 2, but improved in a few ways. The major change is that the paddles were replaced with buttons, which I definitely prefer. Also, the rumble feels much better now. Still wired, but again there's no way around that for third party Xbox controllers. Pretty much everything else is the same as the Pro 2.
PowerA Fusion Pro (Switch, $100) - 9/10. Also quite similar to the Pro 2 for Xbox. Major differences are that is has no rumble whatsoever, it's wired or wireless, has a gyro, and it costs more. Actually, a lot more now, so I think maybe it's discontinued? I only bought it because Gamestop had it on sale for $55 a couple years ago and at that price it was a no-brainer. As far as Switch features, it doesn't have NFC (no third party does) but it can turn on the console wirelessly. The only annoying quirk it has is that if you want to use the headset jack, you have to connect the controller via USB. Everything else about it is great, by far my favorite Switch controller. If you can find one for a decent price somewhere I highly recommend it.
8bitdo Pro 2 (Switch + PC, $50) - 8/10. Solid controller, and superior to the Switch Pro controller in just about every way but nowhere near as good as the PowerA. So for me it's a PC controller pretty much exclusively. Had some problems when brand new with BT connectivity, but firmware updates have fixed all that. Back buttons work great, but you have to connect to PC/tablet/phone to program them, which can be a hassle. And there's only 2 of them. Sticks are too short but fps freeks fit on it perfectly (though I can't remember offhand if it's Xbox or PS that fits). For Switch features, no NFC, no waking the console, and no HD rumble. Can sometimes be found for $40, and nothing else comes close at that price point. BTW, get the G Classic version, it has the best dpad.
8bitdo Ultimate (Switch + PC, $70) - Tried it, returned it. It's not terrible but imo it's just an expensive sidegrade from the Pro 2 that has no real reason to exist. I really don't care about the hall effect thing. Never had a single controller from PS3/4/5, X1X/XSS/XSX, WiiU, Switch, or PC develop drift so I stick with controllers that have all the other important features.