That's a pretty big selling point mind you. Whenever I come back after months of not playing, I can gear up all the chars I feel like playing for like a million each or whatever. Granted prices went down A LOT since they made leveling crafting so easy in ShB, so the difference isn't as big as it used to be(can probably buy a full set for 1.5 to 2m depending on how late you resub compared to the new gear, in SB it was more like 6-8m) but it's still nice to just start playing again and get all your stuff geared up to do content with.
You also can repair anywhere, which is a small qol. Can just repair mid fight if you forgot to and stuff.
It makes pretty good money though, and is fun to do. I'd say the latter is the #1 reason a lot of crafters do it, it's just not selecting an item and pressing craft x 50 to level up, it has a bunch of leveling paths, skills, figuring out rotations, optimizing gear(and the reoptimizing rotations for that new gear) and such, so it's actually interesting to do. Obviously not gonna appeal to everyone, but I like it so even though I don't really sell stuff much anymore and could just buy the armor sets when I play again, I still level and keep my crafters geared.