IT/Software career thread: Invert binary trees for dollars.

  • Guest, it's time once again for the massively important and exciting FoH Asshat Tournament!



    Go here and give us your nominations!
    Who's been the biggest Asshat in the last year? Give us your worst ones!
Cad

Cad

scientia potentia est
<Bronze Donator>
25,806
50,624
Tuco_sl said:
Fun recursive vs iterative CS question:

I'm building a hex tree where each node has the address of its six neighbors if they exist ex:
I start out with one node and as I need to expand the space it occupies I keep adding nodes (and have to assign the new nodes to its neighbors if they exist!!). Once I'm done I need to deallocate the memory space of all those nodes without leaving behind any nodes or double deleting.

I'm going to write the recursive implementation for delete and would be interested to see the iterative implementation.

Note that I might give up and try a completely different and better approach once I realize how slow searching is and how much better octrees or kdtrees are for my problem.

Software engineering bonus question: Find a current implementation that does all this with better performance and reliability than I can.
Click to expand...
Why can't you do something like:

 
Tuco

Tuco

I got Tuco'd!
<Gold Donor>
47,892
82,475
I think that implementation would multi delete. When you add the neighbor to the list you'll have to remove that neighbor's reference to tempNode.
 
Cad

Cad

scientia potentia est
<Bronze Donator>
25,806
50,624
Tuco_sl said:
I think that implementation would multi delete. When you add the neighbor to the list you'll have to remove that neighbor's reference to tempNode.
Click to expand...
Where is the neighbors reference to tempNode ever created? TempNode is a local variable/pointer (depending on language of implementation) used to point at the node we're deleting.
 
Tuco

Tuco

I got Tuco'd!
<Gold Donor>
47,892
82,475
Right, but after you delete that node, won't its neighbors have a reference to it? needing something like
 
Cad

Cad

scientia potentia est
<Bronze Donator>
25,806
50,624
Tuco_sl said:
Right, but after you delete that node, won't its neighbors have a reference to it?
Click to expand...
You're going to systematically delete all the neighbors too. So you'll get those references when you hit them.
 
wormie

Asshat wormie

2023 Asshat Award Winner
<Gold Donor>
16,820
30,968
Your guys use of (... != null) is making me twitch. Please for the love of god (!tempnode.neighbor).
 
T

Tenks

Bronze Knight of the Realm
14,163
607
I find the latter far less readable and it compiles down to the same stuff anyways
 
Tuco

Tuco

I got Tuco'd!
<Gold Donor>
47,892
82,475
I usually use (!tempNode.neighbor) because lazy but use (tempNode.neighbor != null) when describing things to people because it's more explicit and I don't know how pointers work in all language.

Both are about the same to me in terms of readability and probably compile the same.
 
wormie

Asshat wormie

2023 Asshat Award Winner
<Gold Donor>
16,820
30,968
But the standards
frown.png
 
T

Tenks

Bronze Knight of the Realm
14,163
607
My issue is when someone is quickly reading over my code or I quickly read over someone's code parenthesis followed by not operator often blends together. It is too simple to overlook so I'm always very explicit with my null checks anymore.
 
Tuco

Tuco

I got Tuco'd!
<Gold Donor>
47,892
82,475
wormie_sl said:
But the standards
frown.png
Click to expand...
If I made a standard I'd probably make it favoring Tenks. When people get uppity about whether address checks should be !address or address != null it poisons the idea of coding standards.
 
wormie

Asshat wormie

2023 Asshat Award Winner
<Gold Donor>
16,820
30,968
Tuco_sl said:
If I made a standard I'd probably make it favoring Tenks. When people get uppity about whether address checks should be !address or address != null it poisons the idea of coding standards.
Click to expand...
I am mostly being facetious. I just really like code to be as clean as can be.
 
Cad

Cad

scientia potentia est
<Bronze Donator>
25,806
50,624
wormie_sl said:
I am mostly being facetious. I just really like code to be as clean as can be.
Click to expand...
I like it to be really obvious what something is doing so shorthand notations that even slightly obfuscate something for the next monkey that is going to read my code and fuck it up bother me.

Also I quit programming in like 2006 so ... ymmv hah.
 
Citz

Citz

Silver Squire
180
8
I'm used to see != null with C# since you can only use the ! operator on a boolean.
 
wormie

Asshat wormie

2023 Asshat Award Winner
<Gold Donor>
16,820
30,968
Tuco was playing with pointers. The value of a null pointer is equivalent to 0 which is equivalent to false. Thats why !pointer works.
 
Lendarios

Lendarios

Trump's Staff
<Gold Donor>
19,360
-17,424
Which is very language specific. The better code will be a comparison with null, to avoid any misunderstanding. There are languages that allows you do to
int c =4;
if (c == false) then ...
Which compiles and works(by exploding the implementation of bool and int ), but it is not the right way on modern languages.
 
wormie

Asshat wormie

2023 Asshat Award Winner
<Gold Donor>
16,820
30,968
lendarios_sl said:
Which is very language specific. The better code will be a comparison with null, to avoid any misunderstanding. There are languages that allows you do to
int c =4;
if (c == false) then ...
Which compiles and works(by exploding the implementation of bool and int ), but it is not the right way on modern languages.
Click to expand...
My comment was strictly limited to the realm of c/c++ since that is what tuco programs in according to him. As far as I know, and I really don't, !pointer is idiomatic in c.
 
Tuco

Tuco

I got Tuco'd!
<Gold Donor>
47,892
82,475
wormie_sl said:
My comment was strictly limited to the realm of c/c++ since that is what tuco programs in according to him. As far as I know, and I really don't, !pointer is idiomatic in c.
Click to expand...
There's two points here:
1. Only a minority of people reading this thread probably have heavy experience in C, so != null is more clear to people.
2. Even within veterans of C, different programmers use different ways of pointer-checking and to be adament that one way is right is silly.
 
wormie

Asshat wormie

2023 Asshat Award Winner
<Gold Donor>
16,820
30,968
Tuco_sl said:
There's two points here:
1. Only a minority of people reading this thread probably have heavy experience in C, so != null is more clear to people.
2. Even within veterans of C, different programmers use different ways of pointer-checking and to be adament that one way is right is silly.
Click to expand...
I am not adamant about it. Just having a conversation. There is zero difference between the two.
 
O

Obtenor_sl

shitlord
483
0
And here I am as a Ruby Developer thinking "jeez, what a mess, in Ruby you only have to ask: variable.nil?"

That's why I guess I love the Ruby language, it's so like 'natural' language it scares me. 1..5 do { xyz }, or array.each ... or variable.nil?. So easier and natural to perform operations and checks.
 
You must log in or register to reply here.