JC shuffle as we knew it is gone, my jewelcrafter does fuck all so far except upgrade items and the garrison hut daily which nets 200+ gold. Gems sell for loss, or so my addon tells me. So I make upgrade items when I can and they sell ok.
It might still be possible to generate money if you make necks/rings (forgot which) and DE them. Depends on price of ores and dust and it's also a chore. Didn't really try.
Enchanting is nice because your stuff isn't soulbound. All the other tradeskills I have shit out soulbound mats so you have to produce something in order to make money. Enchanting has been my big moneymaker in WoD.
Never been into bags much except MoP 28-slot bag, which had soulbound mats too. I tried frostweave bags for a while but the crafting time was too much for me to suffer through. All that waiting for a profit of 1-2g per bag, nothx. Embersilk bags may be better but even then you can just throw the hypnotic dust on the AH and it will be gobbled up in no time.
I'm sticking to the various upgrade items with tailoring, they sell for profit still.
Inscription made me a nice chunk of money early on in WoD, now glyphs rarely sell. Cards were the shit for a while, but those trinkets have also been surpassed since then, alts aside. Upgrade items sell ok for me.
Engineering makes ok money now, upgrade items sell alright.
Blacksmithing - basically same story, upgrade items sell, everything else gives me less gold per soulbound mat so I don't make them.
Alchemy... well let's not go there.
That's all I have. If I had the nerve to drop tradeskills and relearn, and if it was still early in the expansion, Inscription/Enchanting would be the big $$ I guess.
Salvage yard is always good because the greys give some gold and you get the odd valuable transmog item or (rarely... very rarely) epic BoE (I got 3 so far on 4 max garrison chars). Even if you vendor the greens it's some nice money. Haven't tried 2x tradeskill that the character has plus enchanting hut, that might work out too.
Trading post: get it. seriously. sooner or later you'll be resource capped and then you can buy dusts for 4 resource each, wait for dust trader day, and sell stacks of 200 in the AH quite reliably. Might also work for other mats like fur and leather, didn't really check.