IT/Software career thread: Invert binary trees for dollars.

Khane

Khane

Got something right about marriage
19,851
13,364
moontayle_sl said:
Overheard today that the more senior android dev here was let go after disappearing into the wilds of India. I sort of expected it but was hoping she would find her way back so I didn't have the life of an entire product riding on my junior dev ass, but such is. I'm sort of excited though. Besides, this gives me a chance to clean up her code without someone bitching at me in the process. I seriously think it might have given me aids. Or the flu at least.
Click to expand...
Best way to get experience and learn a bunch.
 
Tuco

Tuco

I got Tuco'd!
<Gold Donor>
45,455
73,543
ShakyJake_sl said:
Fucking code reviews are the bane of my existence. This one guy refuses to listen to anything I say. And I am trying my best to word my comments in such a way that they would not be construed as attacks.

He always falls back to "it's consistent with the rest of the application." Yes, but 90% of the application is shit. So is that justification for writing shitty code?

Furthermore, I hate people who copy/paste shit without understanding what it does.
Click to expand...
Code reviews can go to crap when you have people who fundamentally disagree on programming ideas. When you get to that point I think you have to stick to comments where you can see concrete ways that their code breaks.

lendarios_sl said:
His side last month was...

"Well remember that architecture i was pushing for 2 months ago.. I don't want to use it anymore... I realized it it was not for this company... It requires a full time work on the DB that fullstack developers dont do..."

Translation. After realizing he as alone on the boat of maintaining XML and SP, plus realizing the non re-usability of his architecture he quickly changed his tune. Trying to save face about it, but after giving me 1 moth of unnecessary headaches of "Why don't you want to try new things? Why are you so close minded"??
Mind you my main argument was SQL xml work is not OOP, just string/xml manipulation.
Click to expand...
I hate it when dickheads get trapped in a hole and rather than reflect on why they're up shit creek they hide behind statements like, "This company isn't ready for this." or "If other people don't do X, then my idea won't work.".
 
ShakyJake

ShakyJake

<Donor>
7,642
19,281
Tuco_sl said:
Code reviews can go to crap when you have people who fundamentally disagree on programming ideas. When you get to that point I think you have to stick to comments where you can see concrete ways that their code breaks.
Click to expand...
Yeah, I realize that. That's why I try and offer an alternative approach in a friendly way and don't push the point if they decline. However, in this case there is a fundamental flaw in the way he's designed his class that WILL throw an exception. Yet he'll always respond with, "That'll never happen in the real world." Which is bullshit because it's fucking happening to me during a simple test and I'm not even trying to make it break. What's frustrating is that I have no one to back me up.
 
moontayle

moontayle

Golden Squire
4,302
165
Khane_sl said:
Best way to get experience and learn a bunch.
Click to expand...
Agreed and I'm already light years ahead of where I was when I started... shit it was less than four months ago. Already had my first release and nothing has broken because of it so... yay. But there's that other shit I found while getting the release ready. Like installing debug apks on our devices and not doing a proper upgrade when new apks are sent out. I definitely won't lack for things to learn over the near future. I just don't like that it's because I'm cleaning up someone else's fuckups.
 
Khane

Khane

Got something right about marriage
19,851
13,364
You'll be much better off for it in the long term, even though it's frustrating right now.
 
Lendarios

Lendarios

Trump's Staff
<Gold Donor>
19,360
-17,424
ShakyJake_sl said:
Yeah, I realize that. That's why I try and offer an alternative approach in a friendly way and don't push the point if they decline. However, in this case there is a fundamental flaw in the way he's designed his class that WILL throw an exception. Yet he'll always respond with, "That'll never happen in the real world." Which is bullshit because it's fucking happening to me during a simple test and I'm not even trying to make it break. What's frustrating is that I have no one to back me up.
Click to expand...
My boss believes in Fail Early, Fail Loudly, meaning he don't check if stuff is null he just let it crash. A bit frustrating, but the guy is so damn smart, that i understand his point.
 
Deathwing

Deathwing

<Bronze Donator>
16,426
7,439
Can you explain his view on that a bit more? I work for a company that make static analysis software and missing null checks is one of the things it warns about. It's such a headache to track down later on and such a small cost performance wise, why not do it?
 
Noodleface

Noodleface

A Mod Real Quick
37,961
14,508
We design our stuff with null checks so we can fail gracefully, then again if we let the system go out of control and crazy thermal events start getting through we could do permanent damage.
 
Lendarios

Lendarios

Trump's Staff
<Gold Donor>
19,360
-17,424
Deathwing_sl said:
Can you explain his view on that a bit more? I work for a company that make static analysis software and missing null checks is one of the things it warns about. It's such a headache to track down later on and such a small cost performance wise, why not do it?
Click to expand...
Since our company is small and we only do intern software, he can track and fix exceptions right away. His line of thinking, is that if a null list got in by mistake, rather than having what he calls, unexpected behavior, he'll rather have the method crash, that way he can pin point exactly where the failure was. I don't agree with it, I check for my list to be nulls, but he is the boss.
 
Deathwing

Deathwing

<Bronze Donator>
16,426
7,439
Ah, you have a decent idea of how the software is being used and what information may be passed to it. Those types of situations, skipping null checks might be ok.
 
ShakyJake

ShakyJake

<Donor>
7,642
19,281
lendarios_sl said:
My boss believes in Fail Early, Fail Loudly, meaning he don't check if stuff is null he just let it crash. A bit frustrating, but the guy is so damn smart, that i understand his point.
Click to expand...
The issue is that our guy is assuming a value will always be present in a data set. Since our application allows the user to do custom naming, then it's a situation where the query may not find what it's looking for, returning null. The code is acting on that null value assuming it's, well, not null.

There are certainly situations where I don't check for null because if it IS null then there's a problem and I want it to crash.
 
Deathwing

Deathwing

<Bronze Donator>
16,426
7,439
Well, yeah, that's pretty dumb. Not checking that your query failed to find anything, or you memory allocation failed, or http request returned a None...I mean, how has he not been burned by this already? Should just be habit at this point.
 
Vinen

Vinen

God is dead
2,783
490
Out in Palo Alto right now.

Walking across the VMware Campus at 9 AM felt like being in Sanctus Seru. Empty without any signs of life.

I had to post this here since none of my coworkers would get an EQ1 joke
frown.png
 
Agraza

Agraza

Registered Hutt
6,890
521
I wish Luclin had been as factionally relevant as Velious. I had a soft spot for combine lore, and they totally blew it.
frown.png


Your coworkers suck.
 
Vinen

Vinen

God is dead
2,783
490
Agraza_sl said:
I wish Luclin had been as factionally relevant as Velious. I had a soft spot for combine lore, and they totally blew it.
frown.png


Your coworkers suck.
Click to expand...
Yeah
frown.png
no reformed MMO Players...

But man... the nostalgia as I walked through the Campus.

Best picture I can find... too much green compared to the area behind it which is massive concrete maze.

rrr_img_101188.jpg
 
You must log in or register to reply here.